Support for Sybasease+informix (tpcc and ycsb) #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
reviewed
Dec 1, 2023
| } | ||
| } catch (java.lang.InstantiationException | java.lang.IllegalAccessException ex) { | ||
| throw new RuntimeException("Failed to initialize JDBC driver '" + this.driverClass + "'", ex); | ||
| } |
There was a problem hiding this comment.
nit: please fix the whitespace alignment
bpkroth
reviewed
Dec 1, 2023
| @@ -97,7 +190,7 @@ | |||
| <dependency> | |||
| <groupId>org.mariadb.jdbc</groupId> | |||
| <artifactId>mariadb-java-client</artifactId> | |||
| <version>3.1.4</version> | |||
| <version>2.7.8</version> | |||
bpkroth
reviewed
Dec 1, 2023
| @@ -110,7 +203,7 @@ | |||
| <dependency> | |||
| <groupId>com.google.cloud</groupId> | |||
| <artifactId>google-cloud-spanner-jdbc</artifactId> | |||
| <version>2.9.16</version> | |||
| <version>2.9.13</version> | |||
bpkroth
reviewed
Dec 1, 2023
| @@ -49,6 +49,71 @@ | |||
| </distributionManagement> | |||
|
|
|||
| <profiles> | |||
| <profile> | |||
| <id>arcion</id> | |||
bpkroth
reviewed
Dec 5, 2023
There was a problem hiding this comment.
This will need some testing support. Please have a look at .github/workloads/maven.yml and/or #379 for some examples on how to add that. Thanks!
Just noticed this. Is this a duplicate then? Can you close one of them or combine their changes in a single PR so we're not having to review multiple things? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections as per the comments in #364